logo
Welcome to our new AbleCommerce forums. As a guest, you may view the information here. To post to this forum, you must have a registered account with us, either as a new user evaluating AbleCommerce or an existing user of the application. For all questions related to the older version of Gold and earlier, please go to AbleCommerce Gold forum. Please use your AbleCommerce username and password to Login. New Registrations are disabled.

Notification

Icon
Error

Options
Go to last post Go to first unread
Joe Payne2  
#1 Posted : Tuesday, January 24, 2023 9:32:20 AM(UTC)
Joe Payne2

Rank: Advanced Member

Groups: HelpDesk, Developers
Joined: 11/9/2018(UTC)
Posts: 555

Thanks: 117 times
Was thanked: 23 time(s) in 22 post(s)
In /CommerceBuilder/Services/Scheduler/RecurringOrdersService.cs line 151

When the recurring order is generated, there is no logic to commit sales tax. This is in conflict with the recent addition of the configuration setting for committing taxes during checkout or during order-paid event.

This is a problem because the CheckoutService isn't being used to generate the new order. Ideally the routine should be redesigned to use CheckoutService which then flows nicely with existing logic on processing the new commit-taxes setting.

Wanna join the discussion?! Login to your AbleCommerce Forums forum account. New Registrations are disabled.

shaharyar  
#2 Posted : Thursday, January 26, 2023 6:19:11 AM(UTC)
shaharyar

Rank: Advanced Member

Groups: Admin, Developers, Registered, HelpDesk, Authorized User
Joined: 10/5/2018(UTC)
Posts: 666

Thanks: 5 times
Was thanked: 112 time(s) in 111 post(s)
Your point seems valid. When the recurring order is created, the tax provider recalculates function is called and the taxes will be committed regardless of the commit behavior settings.

I am going to report this.
Thanks
Users browsing this topic
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.